Document what distcheck is intended to exercise
#141646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
Looks like this doesn't currently try to exercise |
ehuss
changed the title
diskcheck is intended to exercisedistcheck is intended to exercise
|
Note there is a typo in the commit message ( |
https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/chkdsk 😁 |
|
(Fixed, thanks) |
|
@bors r+ This seems broadly true to me -- the real 'intent' here is to ensure that the distributed tarballs are actually useful for intended purposes. We do a partial job of that with the steps here today :) |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
May 31, 2025
Rollup of 8 pull requests Successful merges: - #140787 (Note expr being cast when encounter NonScalar cast error) - #141112 (std: note that `std::str::from_utf8*` functions are aliases to `<str>::from_utf8*` methods) - #141646 (Document what `distcheck` is intended to exercise) - #141740 (Hir item kind field order) - #141793 (`tests/ui`: A New Order [1/N]) - #141805 (Update `compiler-builtins` to 0.1.160) - #141815 (Enable non-leaf Frame Pointers for mingw-w64 Arm64 Windows) - #141819 (Fixes for building windows-gnullvm hosts) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
May 31, 2025
Rollup merge of #141646 - jieyouxu:distcheck, r=Mark-Simulacrum Document what `distcheck` is intended to exercise Or at least attempt to. Closes #141387. cc `@marcoieni` (re. [#t-infra/bootstrap > Speed up distcheck](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Speed.20up.20distcheck/with/520208870)) r? `@Mark-Simulacrum` (as you may have some clues about if this is accurate)
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jun 3, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#140787 (Note expr being cast when encounter NonScalar cast error) - rust-lang#141112 (std: note that `std::str::from_utf8*` functions are aliases to `<str>::from_utf8*` methods) - rust-lang#141646 (Document what `distcheck` is intended to exercise) - rust-lang#141740 (Hir item kind field order) - rust-lang#141793 (`tests/ui`: A New Order [1/N]) - rust-lang#141805 (Update `compiler-builtins` to 0.1.160) - rust-lang#141815 (Enable non-leaf Frame Pointers for mingw-w64 Arm64 Windows) - rust-lang#141819 (Fixes for building windows-gnullvm hosts) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or at least attempt to.
Closes #141387.
cc @marcoieni (re. #t-infra/bootstrap > Speed up distcheck)
r? @Mark-Simulacrum (as you may have some clues about if this is accurate)